-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update InfluxDB Docker content.md #2586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update InfluxDB Docker content.md #2586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The overview paragraph should stay general for InfluxDB (not specific to InfluxDB 3).
- If
docker-library
doesn't generate or support a TOC, we need to be clear that the readme contains info for all 3 versions. - We need to make sure we don't lose any existing instructions. I see you're linking to the v1 and v2 docs, which is good, but we need to verify they're comprehensive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample compose.yaml
for all 3 would be nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MeelahMe Some fixes and suggestions.
influxdb/content.md
Outdated
-v $PWD/data:/var/lib/influxdb3 \ | ||
-e INFLUX_LICENSE_KEY="YOUR_LICENSE_KEY" \ | ||
influxdb:enterprise serve \ | ||
--cluster-id cluster1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have an example using available environment variables, specific for Docker startup (if any) and InfluxDB3 variables. Users will want to source them from a file (.env
, for example)
@MeelahMe quay.io is mostly used for internal user testing. Publicly, we
need to point to the official image tags on DockerHub:
https://hub.docker.com/_/influxdb/tags
…On Wed, Jul 2, 2025 at 3:11 PM Jameelah Mercer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In influxdb/content.md
<#2586 (comment)>:
>
-*If you run setup from within the container, InfluxDB stores `influx` CLI [connection configurations](/influxdb/v2/reference/cli/influx/#provide-required-authentication-credentials) in the container's `/etc/influxdb2/influx-configs` file.*
+- **Core:** `quay.io/influxdb/influxdb3:latest` <http://quay.io/influxdb/influxdb3:latest>
@jstirnaman <https://github.com/jstirnaman> Okay, I can change them. Can
you tell me why we should not be pointing to them and where I can find
where to point to?
—
Reply to this email directly, view it on GitHub
<#2586 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABT2AZEBL3SYOLC5V6237D3GQ4IPAVCNFSM6AAAAAB7TQR6ECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSOBQGQ4TIMRRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
influxdb/content.md
Outdated
%%IMAGE%%:1.8 | ||
docker run -d --name influxdb3-core \ | ||
-v influxdb3-data:/var/lib/influxdb3 \ | ||
-p 8086:8086 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...unless you set it explicitly. We should just use the default in this README.
52789b3
to
7b257f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more suggestions--I apparently had a review in progress that I didn't submit.
influxdb/README.md
Outdated
@@ -46,7 +46,7 @@ WARNING: | |||
|
|||
- [`2`, `2.7`, `2.7.12`, `latest`](https://github.com/influxdata/influxdata-docker/blob/abb94994d78be45ccaa56282f36c36ad16bd5a5e/influxdb/2.7/Dockerfile) | |||
|
|||
- [`2-alpine`, `2.7-alpine`, `2.7.12-alpine`, `alpine`](https://github.com/influxdata/influxdata-docker/blob/abb94994d78be45ccaa56282f36c36ad16bd5a5e/influxdb/2.7/alpine/Dockerfile) | |||
- [`2-alpine`, `2.7-alpine`, `2.7.11-alpine`, `alpine`](https://github.com/influxdata/influxdata-docker/blob/abb94994d78be45ccaa56282f36c36ad16bd5a5e/influxdb/2.7/alpine/Dockerfile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [`2-alpine`, `2.7-alpine`, `2.7.11-alpine`, `alpine`](https://github.com/influxdata/influxdata-docker/blob/abb94994d78be45ccaa56282f36c36ad16bd5a5e/influxdb/2.7/alpine/Dockerfile) | |
- [`2-alpine`, `2.7-alpine`, `2.7.12-alpine`, `alpine`](https://github.com/influxdata/influxdata-docker/blob/abb94994d78be45ccaa56282f36c36ad16bd5a5e/influxdb/2.7/alpine/Dockerfile) |
2.7.12 is the latest 2.x tag. Not sure what happened here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm odd I don't remember editing this section. Might be something on my end though.
influxdb/content.fixed.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be a separate file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is not supposed to be a separate file. I don't remember committing to this last night. Let me check what is going on.
… and storage configuration
23cdc0e
to
9371c1a
Compare
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
Co-authored-by: Jason Stirnaman <[email protected]>
I remember now. I was trying to fix the markdown lint CI and made a separate file as a way to test my thoughts. I must have accidentally pushed that file and not the content.md. I will make sure the content.md is up to date with our changes and remove the content.fixed.md. @jstirnaman |
This PR updates the Docker README file to clarify instructions for running the server in a container.
Changes include: